Move VS language-service logic tests to FSharp.Compiler.Service.Tests#20033
Open
T-Gro wants to merge 4 commits into
Open
Move VS language-service logic tests to FSharp.Compiler.Service.Tests#20033T-Gro wants to merge 4 commits into
T-Gro wants to merge 4 commits into
Conversation
Contributor
✅ No release notes required |
T-Gro
force-pushed
the
tests/salsa-tests-logic
branch
3 times, most recently
from
July 7, 2026 13:22
2b223cb to
b434d50
Compare
T-Gro
marked this pull request as ready for review
July 8, 2026 13:21
github-actions
Bot
added
the
AI-Tooling-Check-Bypassed
Port completion, quick info, parameter info, go-to-definition, and diagnostics coverage from the Windows-only VS Salsa suite to the cross-platform FSharp.Compiler.Service.Tests. The legacy suite keeps only the tests that genuinely exercise Visual Studio integration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…Info helper - ScriptDiagnostics closure: use assumeDotNetFramework=false/useSdkRefs=true on coreclr so the script closure resolves FSharp.Core where no .NET Framework exists (Linux/Mac/Win-transparent). - ScriptOptions SurfaceOrderOfHashes: guard #if !NETCOREAPP; it asserts desktop-GAC assemblies (System.Runtime.Remoting/System.Transactions) that cannot resolve on a Core-only host. - Legacy ParameterInfo: delete the now-callerless TestSystematicParameterInfo helper; its wrapper tests were migrated to FCS and a leftover [<Fact>] on the parameterized member failed discovery (0ms). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…the transparent compiler The migrated legacy test only checked that the resolvable reference produced no squiggle; the whole-closure assertClosureNoDiagnostics over-translated it. The transparent compiler surfaces the deliberately-missing reference as a warning (the classic one does not), so filter that expected warning before asserting none remain. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reference/#load script checks funnelled through a shared "Test.fsx" identity, so the .NET Framework FCS checker's filename-keyed script-closure cache leaked one test's resolved/failed references and their diagnostics into another under concurrency (empty #r tooltips; phantom "'' is not a valid assembly name" squiggles). Route those checks through a unique script identity via getParseAndCheckResultsUniqueName. Plain-code tests keep the fast shared path. Remove 13 tests whose asserted behaviour is already covered: duplicates within the migrated set (tooltip PriorityQueue/exception/module-alias, gotodef record fields, paraminfo single-arg/generic-location, an if-clause completion that also lives in the completion suite) and two diagnostics covered by executed ComponentTests (FS0010 negative enum literal, FS0433 entrypoint-not-last). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro
force-pushed
the
tests/salsa-tests-logic
branch
from
July 10, 2026 15:02
f588e1e to
fc3dae3
Compare
abonie
reviewed
Jul 15, 2026
| for item in info.Items do | ||
| match item.NameInCode with | ||
| | "BackgroundColor" -> Assert.Equal(CompletionItemKind.Property, item.Kind) | ||
| | "CancelKeyEvent" -> Assert.Equal(CompletionItemKind.Event, item.Kind) |
Member
There was a problem hiding this comment.
This seems inconsistent with the assertHasItemWithNames [ "BackgroundColor"; "CancelKeyPress" ] info a couple lines above, it should be either "CancelKeyEvent" or "CancelKeyPress" in both, right?
abonie
reviewed
Jul 15, 2026
| () | ||
| [<Fact>] | ||
| let ``Bug2283 - missing reference and nested generic classes`` () = | ||
| let _, checkResults = getParseAndCheckResults """ |
Member
There was a problem hiding this comment.
I believe this should use getParseAndCheckResultsUniqueName (introduced in this PR) to #r affecting other tests.
abonie
requested changes
Jul 15, 2026
github-project-automation
Bot
moved this from New
to In Progress
in F# Compiler and Tooling
Member
|
This is wonderful! I'm glad the new test helpers work well for the code completion tests! 🙂 @T-Gro Could you also update 'Go to definition' tests, so they use the new It could probably either use an additional helper in Checker.fs, or maybe get the selected symbol using the existing API and then use it for the navigation. Though, I'm not sure whether the second approach would test the VS behavior properly. Or maybe add a similar module with VS-specific helpers to the VS-related project, if this navigation is handled by VS? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Visual Studio Salsa unit tests exercised compiler-service logic — completion, quick info, parameter info, go-to-definition, and diagnostics — but only ran on Windows through a mock VS harness. This ports that coverage to the cross-platform FSharp.Compiler.Service.Tests, so it runs on every target the compiler does and no longer depends on Visual Studio.
The ports are behaviour-preserving: each assertion moves onto the equivalent FCS API. The legacy suite keeps only the tests that genuinely exercise Visual Studio integration (project-system, editor events, solution lifecycle).